Do not read SVG parameter from metadata in network area diagram #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-dup
force-pushed
the
nad_update_textnodes_metadata
branch
2 times, most recently
from
de9e28f
to
9405afd
Compare
Signed-off-by: massimo.ferraro <[email protected]>
flo-dup
force-pushed
the
nad_svg_metadata_parameter_removed
branch
from
7dc8bdb
to
197afc4
Compare
flo-dup
previously approved these changes
Aug 7, 2024
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
approved these changes
Aug 7, 2024
flo-dup
pushed a commit
that referenced
this pull request
Oct 31, 2024
Signed-off-by: massimo.ferraro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
In network area diagram viewer, the detailedTextNodeYShift parameter is read from the metadata included in the SVG
What is the new behavior (if this is a feature change)?
In network area diagram viewer, the detailedTextNodeYShift parameter, no more included in the metadata of the SVG, is hardcoded
Does this PR introduce a breaking change or deprecate an API?