Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 2 p #1237

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Fix bug 2 p #1237

merged 8 commits into from
Dec 17, 2024

Conversation

RoxaneChen02
Copy link
Collaborator

@RoxaneChen02 RoxaneChen02 commented Dec 16, 2024

Please check if the PR fulfills these requirements

  • [x ] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

During 2P sensitivity systematic analysis for states without RA the code crashes due to a powsybl error (com.powsybl.commons.PowsyblException: Load flow ended with status CONVERGED <-- load flow converge but outerloop is unstable) that is not properly caught.

What is the new behavior (if this is a feature change)?
Instead of crashing, a SystematicSensitivityResult with status FAILURE is returned (same behavior as during 1P). Plus during sensitivity systematic analysis for states WITH RA, the error is also caught and handled (sensitivity status is set to PARTIAL_FAILURE due to failing perimeter).

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • [ x] No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

CHEN Roxane added 2 commits December 16, 2024 10:46
Signed-off-by: CHEN Roxane <[email protected]>
Signed-off-by: CHEN Roxane <[email protected]>
Godelaine
Godelaine previously approved these changes Dec 16, 2024
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Godelaine
Godelaine previously approved these changes Dec 17, 2024
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Signed-off-by: Godelaine de Montmorillon <[email protected]>
@Godelaine Godelaine merged commit 5e3674c into main Dec 17, 2024
12 checks passed
@Godelaine Godelaine deleted the fix_bug_2P branch December 17, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants