-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature apply action #4
Conversation
08deb55
to
5a0da81
Compare
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
5a0da81
to
180d964
Compare
As mentioned in our meeting end of August, could you guide the furture PR reviewer to things that are most important to look at ? Looking forward for your help in making this smoother, thanks |
Implementation of backend for Grid2opThere is two important files that are really implementing the powsyblBackend in the manner of pandapower backend is implemented in Grid2op. Most of the functions' name are identical, some little bit of architectures might change because of the specificity of Powsybl but they are for most explained in the Readme. One of those file is an help to better load network called Network and is helping to keep DataFrames order when loading loads. The other is our main contribution PowsyblBackend and implements all the needed functions for a backend to work properly with Grid2op and most of optionnal ones except the mananagment of storages and slack buses. Implementation of tests for the integrationThe file to launch test on pytest following integration of pandapower test on Grid2op : general_tests And the related file, very similar to the one in Grid2op, with changes on some values to adapt to powsybl results : BaseBackendTestPyPowsybl Part on chronics creationWe also add a part to create suitable chronics to test our backend on bigger networks because original chronics were having some naming issues that are due to matpower translations. |
Pour cette PR, une evol de pypowsybl a été nécessaire tel que référencée ici: powsybl/pypowsybl#654 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main thing: some tests of grid2op need to be done to make sure the backend is working
Signed-off-by: tschuppr <[email protected]> Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
…ommentaries, adding utility functions Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
…backend action : not set to be working good with xiidm WIP Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
…ding to pypowsybl vision, also replacing the hard coded values signed-off-by: rtschupp <[email protected]>
…with grid2op 1.9.5, WIP to clean code Signed-off-by: rtschupp <[email protected]>
This reverts commit 01e2a76. Signed-off-by: rtschupp <[email protected]>
b87764c
to
185f57a
Compare
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
… reduced Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]>
2148a5d
to
e589340
Compare
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Signed-off-by: rtschupp <[email protected]>
Content of this PRImportant informationYou should read the README.md file to install the environment the right way if you want to test how our implementation is working, a script of simple example is available there. Main file : powsybl_backend.pyWe developed all the principal methods that are mandatory for a backend to work with grid2op:
We also developed some of the optional methods:
We designed methods for the ease of use of our backend:
Test suiteThe tests have been mostly inspired by those of Grid2op. Nevertheless they have been adapted to the particularities of our backend and we reduced their number to focus on the most important. Some data have also been adapted to help the testing see data_test. Those data are using ieee14rte grid and the chronics have been adapted from Grid2op package test case to work with pypowsybl. We also took a file created to generate working chronics from a @BDonnot repo and adapted it for pypowsybl to create synthetic but realist chronics for bigger nets that were not having any chronic available. All the tests are not passing but most of them are. Some more understanding should be done on the reasons (see TODO). Future improvementsPR2The issue concerning this PR is there PR2
PR3This PR will be more specific to the needs of the AIRGo project, more information are available here PR3 TODO
|
Signed-off-by: Yoann Janvier <[email protected]> Signed-off-by: rtschupp <[email protected]> Signed-off-by: Vincent Renault <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]> Signed-off-by: rtschupp <[email protected]> Signed-off-by: Vincent Renault <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]> Co-authored-by: rtschupp <[email protected]> Co-authored-by: Vincent Renault <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]> Co-authored-by: rtschupp <[email protected]> Co-authored-by: Vincent Renault <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]> Co-authored-by: rtschupp <[email protected]> Co-authored-by: Vincent Renault <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]> Co-authored-by: rtschupp <[email protected]> Co-authored-by: Vincent Renault <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]> Co-authored-by: rtschupp <[email protected]> Co-authored-by: Vincent Renault <[email protected]>
Signed-off-by: Yoann Janvier <[email protected]> Co-authored-by: rtschupp <[email protected]> Co-authored-by: Vincent Renault <[email protected]>
[BREAKING] First Pull request into master branch. This request contains the first version of the PypowsyblBackend class and has been launched with error-fee executions on the cases 14 and 1888 from RTE.
[NEW] First implementation of the PypowsyblBackend class with its main methods : apply_action, load_grid, runpf and get_topo_vect.
[NEW] Some unit tests in the Python script test_PowsyblBackend.py.
[TODO] Investigate slack bus' and shunts' behaviour, manage storages and fix bug caused by the move_connectable function from the pypowsybl interface on the generators elements.
[TODO] Increase the rate of OK unit tests