Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adds to the explorer's NAD tab an expand and remove node feature #42

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CBiasuzzi
Copy link
Contributor

@CBiasuzzi CBiasuzzi commented Jan 21, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

adds a new feature that allows to remove and expand the NAD on a diagram's node, in the explorer's NAD tab

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Please note that this feature currently needs:

  • pypowsybl > v1.9.0 ( a version that includes the function get_network_area_diagram with the additional parameter fixed_positions )

The version in this PR shows a buttons bar in the NAD tab; the semantic of the mouse select action (SHIFT+CLICK on a node) in the NAD depends on the buttons bar current selection (go to VL/expand/remove).

An improved (and more recent) version, with a context popup menu on the NAD's VL nodes with the options (go to VL/expand/remove) is available in the PR #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant