Tap controllers from pandapower #887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankur Arohi <[email protected]>
|
Tests are already provided in the previous PR from @geofjamg, this PR aims to change the value of tap position based on special attributes set in pandapower network. |
geofjamg
requested changes
Nov 12, 2024
Signed-off-by: Ankur Arohi <[email protected]>
|
AnkurArohi
changed the title
|
@geofjamg I have worked on your comments |
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
|
geofjamg
reviewed
Jan 28, 2025
There was a problem hiding this comment.
I'm not sure to understand whar you are trying to solve in this PR:
- Are you trying to take into account the effect of the phase shifter to the voltage ratio ? in that case could you give me a link to the pandapower doc describing this.
- Why are you not also creating a phase tap changer with the given phase shift. It seems to me the most important part of a ĥase shifter to take into account.
- Could you add a test case with a phase shifter to how the issue before and solved one after ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankur Arohi [email protected]
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: