Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Build the doc" section in the readme #941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

alicecaron
Copy link

@alicecaron alicecaron commented Feb 7, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Regroup all the documentation instructions in a docs/README.md file and link it from the main README file.
Now the documentation should be built in the docs/_build folder with the make or sphinx commands.

Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The drawback of putting it in a separate README.md is that you need to describe the two options (terminal / IDE GUI) instead of a single one. See https://github.com/powsybl/powsybl-core/blob/main/docs/README.md for an example.

Besides you get an annoying warning each time you build the docs, as the README.md is not included in the toctree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: TODO
Development

Successfully merging this pull request may close these issues.

2 participants