Update: Theme Style

.github/CONTRIBUTING.md

@@ -0,0 +1,34 @@
+# Contributing to MobileCore
+
+We want to make contributing to this project as easy and transparent as possible. Here are a few guidelines for making all our lives easier.
+
+## Reporting Issues
+
+A great way to contribute to the project is to send a detailed issue when you encounter an problem.
+It is very important to check for the same problem or suggestion in the project's issue list first. If you find a match, just add a small comment there.
+Doing this helps prioritize the most common problems and requests.
+
+When reporting issues, please include the following:
+
+- The platform name and version (e.g. iOS 13)
+- The application version or commit hash
+- The version of Xcode you're using
+- The full output of any stack trace or compiler error
+- Any other details that would be useful in understanding the problem
+
+This information will help us review and fix your issue faster.
+
+Please do not be offended if we close your issue and reference this document.
+If you believe the issue is truly a fault in the project’s codebase, re-open it.
+
+## Pull Requests
+
+We gladly accept any PR's assuming they are well written, documented ( if necessary ) and preferably have test code.
+If you're unsure if we'll accept a new feature please open an issue requesting it and we can have a discussion before you code and submit a PR.
+
+Checklist:
+- Fork the repo and create your branch from the latest master (to minimize the conflicts)
+- If you've added code that should be tested, add tests.
+- If you've changed APIs, update the documentation.
+- Ensure the test suite passes.
+- Make sure your code lints (swiftlint).

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,19 @@
+<!--
+ℹ Please fill out this template when filing an issue. All lines beginning with an ℹ symbol instruct you with what info we expect.
+
+Please, read the [CONTRIBUTING guide](https://github.com/ppraveentr/MobileCore/blob/master/.github/CONTRIBUTING.md) before submitting the PR or reporting a bug.
+-->
+
+# Report
+
+## What did you do?
+
+ℹ Please replace this with what you did.
+
+## What did you expect to happen?
+
+ℹ Please replace this with what you expected to happen.
+
+## What happened instead?
+
+ℹ Please replace this with of what happened instead.

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,10 @@
+<!--
+If your pull request fixes an issue, please reference the issue.
+For example, when your pull request fixes issue 10, add the following line:
+
+Fixes #10
+
+This will make sure that when the pull request is merged, we can close the relavent issue accordingly.
+
+Please, read the [CONTRIBUTING guide](https://github.com/ppraveentr/MobileCore/blob/master/.github/CONTRIBUTING.md) before submitting the PR or reporting a bug.
+-->

.github/stale.yml

@@ -0,0 +1,31 @@
+
+# Configuration for probot-stale - https://github.com/probot/stale
+
+# Number of days of inactivity before an Issue or Pull Request becomes stale
+daysUntilStale: 30
+
+# Number of days of inactivity before a stale Issue or Pull Request is closed
+daysUntilClose: 7
+
+# Issues or Pull Requests with these labels will never be considered stale
+exemptLabels:
+  - "enhancement"
+  - "confirmed bug"
+
+# Label to use when marking as stale
+staleLabel: stale
+
+# Comment to post when marking as stale. Set to `false` to disable
+markComment: >
+  This issue has been marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs.
+# Comment to post when removing the stale label. Set to `false` to disable
+unmarkComment: false
+
+# Comment to post when closing a stale Issue or Pull Request. Set to `false` to disable
+closeComment: >
+  This issue has been auto-closed because there hasn't been any activity for at least 37 days.
+  However, we really appreciate your contribution, so thank you for that! 🙏
+  Also, feel free to [open a new issue]https://github.com/ppraveentr/MobileCore/issues/new) if you still experience this problem 👍.
+# Limit to only `issues`
+only: issues

.github/workflows/on-push.yml

@@ -12,6 +12,8 @@ jobs:
     - uses: actions/checkout@v2
     - name: Install Bundle
       run: bundle install
+    - name: Install Swiftlint
+      run: brew install swiftlint
     - name: Run swiftlint
       run: bundle exec fastlane lint
 
@@ -29,7 +31,5 @@ jobs:
       run: bundle exec fastlane test
       env:
          destination: ${{ matrix.destination }}
-    - name: Pod Lib Lint
-      run: bundle exec fastlane podlibLint
     - name: Updload to codecov
       run: bash <(curl -s https://codecov.io/bash)

.github/workflows/pod-deploy.yml

@@ -12,6 +12,8 @@ jobs:
     - uses: actions/checkout@v2
     - name: Install Bundle
       run: bundle install
+    - name: Install Swiftlint
+      run: brew install swiftlint
     - name: Run swiftlint
       run: bundle exec fastlane lint
 

Example/MobileCoreExample.xcodeproj/project.pbxproj

@@ -3,7 +3,7 @@
 	archiveVersion = 1;
 	classes = {
 	};
-	objectVersion = 52;
+	objectVersion = 60;
 	objects = {
 
 /* Begin PBXBuildFile section */
@@ -12,6 +12,12 @@
 		D44E56F92341CFAB00A0E56C /* UIKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D44E56F82341CFAB00A0E56C /* UIKit.framework */; };
 		D49FE3182345D45A002B3742 /* SampleTableViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D49FE3162345D459002B3742 /* SampleTableViewController.swift */; };
 		D49FE3192345D45A002B3742 /* ViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D49FE3172345D459002B3742 /* ViewController.swift */; };
+		D4E050642CCB470B0028D1CE /* MobileTheming in Frameworks */ = {isa = PBXBuildFile; productRef = D4E050632CCB470B0028D1CE /* MobileTheming */; };
+		D4E050672CCB4A5D0028D1CE /* AppTheming in Frameworks */ = {isa = PBXBuildFile; productRef = D4E050662CCB4A5D0028D1CE /* AppTheming */; };
+		D4E050692CCB4A5D0028D1CE /* CoreComponents in Frameworks */ = {isa = PBXBuildFile; productRef = D4E050682CCB4A5D0028D1CE /* CoreComponents */; };
+		D4E0506B2CCB4A5D0028D1CE /* CoreUtility in Frameworks */ = {isa = PBXBuildFile; productRef = D4E0506A2CCB4A5D0028D1CE /* CoreUtility */; };
+		D4E0506D2CCB4A5D0028D1CE /* MobileTheming in Frameworks */ = {isa = PBXBuildFile; productRef = D4E0506C2CCB4A5D0028D1CE /* MobileTheming */; };
+		D4E0506F2CCB4A5D0028D1CE /* NetworkLayer in Frameworks */ = {isa = PBXBuildFile; productRef = D4E0506E2CCB4A5D0028D1CE /* NetworkLayer */; };
 		DE2A6A3426A4199A001F1FF3 /* AppTheming in Frameworks */ = {isa = PBXBuildFile; productRef = DE2A6A3326A4199A001F1FF3 /* AppTheming */; };
 		DE2A6A3626A4199A001F1FF3 /* CoreComponents in Frameworks */ = {isa = PBXBuildFile; productRef = DE2A6A3526A4199A001F1FF3 /* CoreComponents */; };
 		DE2A6A3826A4199A001F1FF3 /* CoreUtility in Frameworks */ = {isa = PBXBuildFile; productRef = DE2A6A3726A4199A001F1FF3 /* CoreUtility */; };
@@ -78,9 +84,9 @@
 		DE9221D31EF28CDF000C8FC7 /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };
 		DE9221D61EF28CDF000C8FC7 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = "<group>"; };
 		DE9221D81EF28CDF000C8FC7 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
-		DE9FF335269F406D0020E855 /* workflows */ = {isa = PBXFileReference; lastKnownFileType = folder; name = workflows; path = ../.github/workflows; sourceTree = "<group>"; };
 		DE9FF336269F413C0020E855 /* Gemfile */ = {isa = PBXFileReference; lastKnownFileType = text; name = Gemfile; path = ../Gemfile; sourceTree = "<group>"; };
 		DE9FF337269F414E0020E855 /* fastlane */ = {isa = PBXFileReference; lastKnownFileType = folder; name = fastlane; path = ../fastlane; sourceTree = "<group>"; };
+		DEB664C426B6763000A18E47 /* .github */ = {isa = PBXFileReference; lastKnownFileType = folder; name = .github; path = ../.github; sourceTree = "<group>"; };
 		DEBDC8931EF4508900AC77A9 /* MobileCoreExample-Bridging-Header.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "MobileCoreExample-Bridging-Header.h"; sourceTree = "<group>"; };
 		DEBDC8A21EF4520100AC77A9 /* MobileCoreExample.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = MobileCoreExample.entitlements; sourceTree = "<group>"; };
 		DEF68499269AEE3A00215BFE /* .swiftlint.yml */ = {isa = PBXFileReference; lastKnownFileType = text.yaml; name = .swiftlint.yml; path = ../.swiftlint.yml; sourceTree = "<group>"; };
@@ -98,12 +104,18 @@
 			isa = PBXFrameworksBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				D4E0506D2CCB4A5D0028D1CE /* MobileTheming in Frameworks */,
+				D4E0506B2CCB4A5D0028D1CE /* CoreUtility in Frameworks */,
 				DE2A6A3826A4199A001F1FF3 /* CoreUtility in Frameworks */,
+				D4E0506F2CCB4A5D0028D1CE /* NetworkLayer in Frameworks */,
+				D4E050642CCB470B0028D1CE /* MobileTheming in Frameworks */,
 				DE2A6A3C26A419A3001F1FF3 /* Foundation.framework in Frameworks */,
+				D4E050692CCB4A5D0028D1CE /* CoreComponents in Frameworks */,
 				DE2A6A3626A4199A001F1FF3 /* CoreComponents in Frameworks */,
 				DE2A6A3A26A4199A001F1FF3 /* NetworkLayer in Frameworks */,
 				D44E56F92341CFAB00A0E56C /* UIKit.framework in Frameworks */,
 				DE2A6A3426A4199A001F1FF3 /* AppTheming in Frameworks */,
+				D4E050672CCB4A5D0028D1CE /* AppTheming in Frameworks */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -134,11 +146,11 @@
 		D49FE30E2345D2A4002B3742 /* CI-CD Setup */ = {
 			isa = PBXGroup;
 			children = (
+				DEB664C426B6763000A18E47 /* .github */,
 				DE63A3A826A416BF003DE96D /* Package.swift */,
 				D47590162317A68A00080D78 /* MobileCore.podspec */,
 				DE9FF336269F413C0020E855 /* Gemfile */,
 				DE9FF337269F414E0020E855 /* fastlane */,
-				DE9FF335269F406D0020E855 /* workflows */,
 				D49FE3132345D2FC002B3742 /* .gitignore */,
 				DEF68499269AEE3A00215BFE /* .swiftlint.yml */,
 				D49FE30F2345D2F1002B3742 /* .codecov.yml */,
@@ -273,6 +285,12 @@
 				DE2A6A3526A4199A001F1FF3 /* CoreComponents */,
 				DE2A6A3726A4199A001F1FF3 /* CoreUtility */,
 				DE2A6A3926A4199A001F1FF3 /* NetworkLayer */,
+				D4E050632CCB470B0028D1CE /* MobileTheming */,
+				D4E050662CCB4A5D0028D1CE /* AppTheming */,
+				D4E050682CCB4A5D0028D1CE /* CoreComponents */,
+				D4E0506A2CCB4A5D0028D1CE /* CoreUtility */,
+				D4E0506C2CCB4A5D0028D1CE /* MobileTheming */,
+				D4E0506E2CCB4A5D0028D1CE /* NetworkLayer */,
 			);
 			productName = FTMobileCoreSample;
 			productReference = DE9221C91EF28CDF000C8FC7 /* MobileCoreExample.app */;
@@ -320,7 +338,7 @@
 			);
 			mainGroup = DE9221C01EF28CDF000C8FC7;
 			packageReferences = (
-				DE2A6A3226A41980001F1FF3 /* XCRemoteSwiftPackageReference "MobileCore" */,
+				D4E050652CCB4A5D0028D1CE /* XCLocalSwiftPackageReference "../../MobileCore" */,
 			);
 			productRefGroup = DE9221CA1EF28CDF000C8FC7 /* Products */;
 			projectDirPath = "";
@@ -359,6 +377,7 @@
 /* Begin PBXShellScriptBuildPhase section */
 		D437653C230E8E5B004974CC /* swiftlint Run Script */ = {
 			isa = PBXShellScriptBuildPhase;
+			alwaysOutOfDate = 1;
 			buildActionMask = 2147483647;
 			files = (
 			);
@@ -440,7 +459,7 @@
 				DEVELOPMENT_TEAM = W6W48SVQX7;
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				INFOPLIST_FILE = MobileCoreTests/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 16.6;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
 					"@executable_path/Frameworks",
@@ -471,7 +490,7 @@
 				DEVELOPMENT_TEAM = W6W48SVQX7;
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				INFOPLIST_FILE = MobileCoreTests/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 16.6;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
 					"@executable_path/Frameworks",
@@ -540,15 +559,15 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 16.6;
 				MTL_ENABLE_DEBUG_INFO = YES;
 				ONLY_ACTIVE_ARCH = YES;
 				OTHER_SWIFT_FLAGS = "-Onone";
 				SDKROOT = iphoneos;
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
 				SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
-				SWIFT_VERSION = 5.0;
+				SWIFT_VERSION = 6.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};
 			name = Debug;
@@ -599,14 +618,14 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 16.6;
 				MTL_ENABLE_DEBUG_INFO = NO;
 				OTHER_SWIFT_FLAGS = "";
 				SDKROOT = iphoneos;
 				SWIFT_COMPILATION_MODE = wholemodule;
 				SWIFT_OPTIMIZATION_LEVEL = "-O";
 				SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
-				SWIFT_VERSION = 5.0;
+				SWIFT_VERSION = 6.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 				VALIDATE_PRODUCT = YES;
 			};
@@ -625,17 +644,18 @@
 				DEVELOPMENT_TEAM = W6W48SVQX7;
 				FRAMEWORK_SEARCH_PATHS = "$(inherited)";
 				INFOPLIST_FILE = "$(TARGET_NAME)/Info.plist";
-				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+				INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.developer-tools";
+				IPHONEOS_DEPLOYMENT_TARGET = 16.6;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 0.1.2;
+				MARKETING_VERSION = 1.0.0;
 				OTHER_SWIFT_FLAGS = "$(inherited)";
 				PRODUCT_BUNDLE_IDENTIFIER = "com.ft.$(TARGET_NAME)";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
-				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG -warn-long-expression-type-checking=300";
+				SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
 				SWIFT_OBJC_BRIDGING_HEADER = "$(SWIFT_MODULE_NAME)/$(SWIFT_MODULE_NAME)-Bridging-Header.h";
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
 				SWIFT_TREAT_WARNINGS_AS_ERRORS = NO;
@@ -656,12 +676,13 @@
 				DEVELOPMENT_TEAM = W6W48SVQX7;
 				FRAMEWORK_SEARCH_PATHS = "$(inherited)";
 				INFOPLIST_FILE = "$(TARGET_NAME)/Info.plist";
-				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+				INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.developer-tools";
+				IPHONEOS_DEPLOYMENT_TARGET = 16.6;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 0.1.2;
+				MARKETING_VERSION = 1.0.0;
 				OTHER_SWIFT_FLAGS = "$(inherited) -D";
 				PRODUCT_BUNDLE_IDENTIFIER = "com.ft.$(TARGET_NAME)";
 				PRODUCT_NAME = "$(TARGET_NAME)";
@@ -704,18 +725,38 @@
 		};
 /* End XCConfigurationList section */
 
-/* Begin XCRemoteSwiftPackageReference section */
-		DE2A6A3226A41980001F1FF3 /* XCRemoteSwiftPackageReference "MobileCore" */ = {
-			isa = XCRemoteSwiftPackageReference;
-			repositoryURL = "https://github.com/ppraveentr/MobileCore.git";
-			requirement = {
-				branch = master;
-				kind = branch;
-			};
+/* Begin XCLocalSwiftPackageReference section */
+		D4E050652CCB4A5D0028D1CE /* XCLocalSwiftPackageReference "../../MobileCore" */ = {
+			isa = XCLocalSwiftPackageReference;
+			relativePath = ../../MobileCore;
 		};
-/* End XCRemoteSwiftPackageReference section */
+/* End XCLocalSwiftPackageReference section */
 
 /* Begin XCSwiftPackageProductDependency section */
+		D4E050632CCB470B0028D1CE /* MobileTheming */ = {
+			isa = XCSwiftPackageProductDependency;
+			productName = MobileTheming;
+		};
+		D4E050662CCB4A5D0028D1CE /* AppTheming */ = {
+			isa = XCSwiftPackageProductDependency;
+			productName = AppTheming;
+		};
+		D4E050682CCB4A5D0028D1CE /* CoreComponents */ = {
+			isa = XCSwiftPackageProductDependency;
+			productName = CoreComponents;
+		};
+		D4E0506A2CCB4A5D0028D1CE /* CoreUtility */ = {
+			isa = XCSwiftPackageProductDependency;
+			productName = CoreUtility;
+		};
+		D4E0506C2CCB4A5D0028D1CE /* MobileTheming */ = {
+			isa = XCSwiftPackageProductDependency;
+			productName = MobileTheming;
+		};
+		D4E0506E2CCB4A5D0028D1CE /* NetworkLayer */ = {
+			isa = XCSwiftPackageProductDependency;
+			productName = NetworkLayer;
+		};
 		DE2A6A3326A4199A001F1FF3 /* AppTheming */ = {
 			isa = XCSwiftPackageProductDependency;
 			productName = AppTheming;

Example/MobileCoreExample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -2,12 +2,12 @@
   "object": {
     "pins": [
       {
-        "package": "MobileCore",
-        "repositoryURL": "https://github.com/ppraveentr/MobileCore.git",
+        "package": "MobileTheme",
+        "repositoryURL": "https://github.com/ppraveentr/MobileTheme.git",
         "state": {
-          "branch": "feature/SPM-Setup",
-          "revision": "272f5ac227e18869e191ca2474e7da74394c26a2",
-          "version": null
+          "branch": null,
+          "revision": "8e321347fc520ea04d1fa6e49a0bd5765cc4f49b",
+          "version": "1.2.0"
         }
       }
     ]

Example/MobileCoreExample/AppDelegate.swift

@@ -13,7 +13,7 @@ import NetworkLayer
 import AppTheming
 #endif
 
-@UIApplicationMain
+@main
 class AppDelegate: UIResponder, UIApplicationDelegate {
     var kBundle = Bundle(for: AppDelegate.self)
     var window: UIWindow?

Example/MobileCoreExample/Classes/ViewController.swift

@@ -5,6 +5,10 @@
 //  Copyright © 2017 Praveen Prabhakar. All rights reserved.
 //
 
+#if canImport(AppTheming)
+import AppTheming
+import CoreComponents
+#endif
 import UIKit
 import WebKit