Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip writing unranked beatmaps to osu_beatmap_difficulty_attribs #232

Merged
merged 7 commits into from
May 30, 2024

Conversation

smoogipoo
Copy link
Contributor

A while back, we trimmed all attributes for unranked beatmaps from the osu_beatmap_difficulty_attribs table. This was done for space-saving reasons.

Without this PR, these attributes are still being written for all new beatmaps and for full reprocesses.

Of particular importance, note that:

  • I haven't stopped writing of scoring attribs. It may be safe to not write them too, but I would rather not break anything there for now. This table is quite small anyway.
  • This still writes to osu_beatmap_difficulty, where we may have decided to keep the star rating written to during the previous trimming.
  • It now always queries osu_beatmaps, once for each beatmap. I'm hoping the overhead here is pretty minimal.

Haven't really tested this yet.

@peppy peppy self-requested a review May 30, 2024 04:24
@peppy peppy merged commit 77be90d into ppy:master May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants