Skip to content

Commit

Permalink
Merge pull request #6162 from ppy/revert-6155-debox-ibindblelist-enum…
Browse files Browse the repository at this point in the history
…erator

Revert "Fix `IBindableList.GetEnumerator()` boxing and allocating"
  • Loading branch information
peppy authored Jan 31, 2024
2 parents a639ba6 + e10051e commit 121d25c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion osu.Framework/Bindables/IBindableList.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ sealed IBindableList<T> BindTarget
/// <inheritdoc cref="IBindable.GetBoundCopy"/>
IBindableList<T> GetBoundCopy();

new List<T>.Enumerator GetEnumerator();
// We want this enumerator to reduce enumeration overhead, but it causes mono / android crashes for silly reasons.
// See https://sentry.ppy.sh/share/issue/c7cda39d8ab94897a2bb350059fd3652/

// new List<T>.Enumerator GetEnumerator();
}
}

0 comments on commit 121d25c

Please sign in to comment.