Merge pull request #10351 from nanaya/feature-vote-confirm

Add confirmation when voting for feature
ppy · Jul 7, 2023 · 91e35d4 · 91e35d4
2 parents d4e54b9 + 7699d8b
commit 91e35d4
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/resources/views/forum/topics/_feature_vote.blade.php b/resources/views/forum/topics/_feature_vote.blade.php
@@ -2,6 +2,9 @@
     Copyright (c) ppy Pty Ltd <[email protected]>. Licensed under the GNU Affero General Public License v3.0.
     See the LICENCE file in the repository root for full licence text.
 --}}
+@php
+    $currentUser = Auth::user();
+@endphp
 <div class="forum-topic-feature-vote">
     <div class="forum-topic-feature-vote__info">
         {!! osu_trans('forum.topics.show.feature_vote.info._', [
@@ -31,15 +34,16 @@ class="
         ]) }}
     </div>
 
-    @if (Auth::check())
+    @if ($currentUser !== null)
         <div class="forum-topic-feature-vote__button">
             <button
                 class="btn-osu-big btn-osu-big--forum-primary"
+                data-confirm="{{ osu_trans('common.confirmation') }}"
                 data-url="{{ route('forum.topics.vote-feature', $topic->getKey()) }}"
                 data-method="POST"
                 data-remote=1
                 data-disable-with="{{ osu_trans('common.buttons.saving') }}"
-                @if (Auth::user()->osu_featurevotes < App\Models\Forum\FeatureVote::COST)
+                @if ($currentUser->osu_featurevotes < App\Models\Forum\FeatureVote::COST)
                     disabled
                 @endif
             >
@@ -49,7 +53,7 @@ class="btn-osu-big btn-osu-big--forum-primary"
 
         <div class="forum-topic-feature-vote__remaining">
             {!! osu_trans('forum.topics.show.feature_vote.user.current', [
-                'votes' => '<strong>'.osu_trans_choice('forum.topics.show.feature_vote.user.count', Auth::user()->osu_featurevotes).'</strong>',
+                'votes' => '<strong>'.osu_trans_choice('forum.topics.show.feature_vote.user.count', $currentUser->osu_featurevotes).'</strong>',
             ]) !!}
         </div>
     @endif