Merge pull request #11504 from nanaya/str-replace-null

Fix null being passed to str replace
ppy · Sep 24, 2024 · 9d30f8e · 9d30f8e
2 parents 9f27725 + d24e913
commit 9d30f8e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/app/Libraries/Markdown/Osu/DocumentProcessor.php b/app/Libraries/Markdown/Osu/DocumentProcessor.php
@@ -148,7 +148,9 @@ private function loadToc()
         }
 
         $title = presence($this->getText($this->node));
-        $slug = $this->node->data['attributes']['id'] ?? presence(mb_strtolower(str_replace(' ', '-', $title))) ?? 'page';
+        $slug = $this->node->data['attributes']['id']
+            ?? presence(mb_strtolower(strtr($title ?? '', ' ', '-')))
+            ?? 'page';
 
         if (array_key_exists($slug, $this->tocSlugs)) {
             $this->tocSlugs[$slug] += 1;