Skip to content

Commit

Permalink
pass whole response in
Browse files Browse the repository at this point in the history
  • Loading branch information
notbakaneko committed Jul 26, 2023
1 parent 102ef05 commit f222821
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
8 changes: 7 additions & 1 deletion resources/js/beatmap-discussions/discussions-state.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,17 @@ import BeatmapsetWithDiscussionsJson from 'interfaces/beatmapset-with-discussion
import GameMode from 'interfaces/game-mode';
import { maxBy } from 'lodash';
import { action, computed, makeObservable, observable, toJS } from 'mobx';
import BeatmapsetDiscussionsStore from 'models/beatmapset-discussions-store';
import moment from 'moment';
import core from 'osu-core-singleton';
import { findDefault, group, sortWithMode } from 'utils/beatmap-helper';
import { makeUrl, parseUrl } from 'utils/beatmapset-discussion-helper';
import { switchNever } from 'utils/switch-never';
import { Filter, filters } from './current-discussions';
import DiscussionMode, { DiscussionPage, discussionModes, isDiscussionPage } from './discussion-mode';
import BeatmapsetDiscussionsStore from 'models/beatmapset-discussions-store';

export interface UpdateOptions {
beatmap_discussion_post_ids: number[];
beatmapset: BeatmapsetWithDiscussionsJson;
watching: boolean;
}
Expand Down Expand Up @@ -379,10 +380,15 @@ export default class DiscussionsState {
@action
update(options: Partial<UpdateOptions>) {
const {
beatmap_discussion_post_ids,
beatmapset,
watching,
} = options;

if (beatmap_discussion_post_ids != null) {
this.markAsRead(beatmap_discussion_post_ids);
}

if (beatmapset != null) {
this.store.beatmapset = beatmapset;
}
Expand Down
3 changes: 1 addition & 2 deletions resources/js/beatmap-discussions/new-reply.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ export class NewReply extends React.Component<Props> {
.done((json) => runInAction(() => {
this.editing = false;
this.setMessage('');
this.props.discussionsState.update({ beatmapset: json.beatmapset });
this.props.discussionsState.markAsRead(json.beatmap_discussion_post_ids);
this.props.discussionsState.update(json);
}))
.fail(onError)
.always(action(() => {
Expand Down

0 comments on commit f222821

Please sign in to comment.