Convert modding profile component to typescript #10311
Conversation
|
|
||
| import UserExtendedJson from './user-extended-json'; | ||
|
|
||
| type ProfileHeaderIncludes = |
There was a problem hiding this comment.
this should go in user-json and also used for typing in profile-page/extra-page-props.
| // add space for warning banner when user is blocked | ||
| modifiers={{ | ||
| restricted: core.currentUserModel.blocks.has(this.props.user.id) || this.props.user.is_restricted, | ||
| }} |
There was a problem hiding this comment.
apparently I missed this one but this doesn't do anything anymore
| </div> | ||
| <div | ||
| ref={this.pagesOffsetRef} | ||
| className='hidden-xs page-extra-tabs page-extra-tabs--profile-page' |
There was a problem hiding this comment.
the hidden-xs shouldn't be here anymore
| } | ||
|
|
||
| let preferred: Page | undefined; | ||
| const pageIds = [...matching.values()]; |
| @@ -4,4 +4,4 @@ | |||
| import ReviewEditorConfigJson from 'interfaces/review-editor-config-json'; | |||
| import * as React from 'react'; | |||
|
|
|||
| export const ReviewEditorConfigContext = React.createContext({} as ReviewEditorConfigJson); | |||
| export const ReviewEditorConfigContext = React.createContext<ReviewEditorConfigJson>({ max_blocks: 0 }); | |||
There was a problem hiding this comment.
what's this change doing here 🤔 although I guess it's simple enough so this can stay
There was a problem hiding this comment.
max_blocks isn't supposed to be undefined and this just makes the default 0 so pages that don't need editing can skip adding a provider without causing max_blocks to be undefined
| ); | ||
| } | ||
|
|
||
| private extraPage = (name: ModdingExtraPage) => { |
There was a problem hiding this comment.
I think some of the components should be observer? ...or not? 🤔
There was a problem hiding this comment.
I wonder about that 🤔 (apparently everything that receives an observable prop should also be an observer, otherwise it's supposed to be toJSd even if the props don't change? 🤔 )
There was a problem hiding this comment.
yeah because otherwise when passing object and any of its properties get updated the non-observer component will be outdated. The toJS tells that the current component do access the properties so it'll update its children accordingly. Although in this case there's no update involved so it should be fine...? I'd probably still make them observer anyway just in case.
getSnapshotBeforeUpdate() needs to return a snapshot or null; we don't really need to handle it on the modding profile page at the moment since the only lazy loaded section is the last one.
now using a copy of the
pageScan/Jumplogic from the main profile page (also there's an existing problem of lazy loaded images shifting the scroll position)