Mark UserCompact.default_group as nullable in api docs
#10319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
requested changes
Jun 30, 2023
|
I think I've updated things correctly, let me know. Not 100% on the difference between the typescript |
nanaya
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has a default usergroup of e.g.
34,default_groupwill be null for them in api responses. I'm guessing this is becauseidentifieris null at a database level for certain groups, including the above.I was going to suggest that
identifiershould be set in the db for all groups. But that could lead to the identifier being leaked for hidden groups if someone manages to find a user in that group and make the appropriate api call, so I'm not sure that's such a good idea anymore.