Remove store address editing #10321
Merged
Remove store address editing #10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the invoice printing related stuff be removed as well? Or at least the copies parameter and javascript for auto printing it. |
notbakaneko
force-pushed
the
feature/remove-address-edit
branch
from
24ab58c
to
85f5ec3
Compare
|
printing and shipping-only versions probably not needed either, without shipping being handled on our end 🤔 |
nanaya
approved these changes
Jun 30, 2023
| @@ -19,13 +19,8 @@ | |||
| </div> | |||
| @endif | |||
|
|
|||
| @for ($i = 0; $i < $copies; $i++) | |||
| @if ($i > 0) | |||
| <div class='print-page-break'></div> | |||
There was a problem hiding this comment.
the class style can be removed
nanaya
requested changes
Jun 30, 2023
nanaya
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer supported, handling of physical item shipping has gone via shopify partners for a while now.
Extra validation that forces an error if a non-shopify shippable item tries to checkout.
Placeholders hardcoded for old invoices.
closes #9490