Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-AWS S3 compatible storage #10414

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Jul 26, 2023

I think a null endpoint should be fine for using aws s3 since that's the current default.

notbakaneko
notbakaneko previously approved these changes Jul 31, 2023
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to working for non-aws 🤔

Something to note before we try switching, is any operation using the s3 filesystem will fail silently if there's an error unless 'throw' => true is set in the config

@nanaya nanaya dismissed notbakaneko’s stale review July 31, 2023 10:09

The merge-base changed after approval.

Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@notbakaneko notbakaneko merged commit e1911a2 into ppy:master Jul 31, 2023
3 checks passed
@nanaya nanaya deleted the s3-custom branch August 1, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants