Cleanup layout footer gap #10435
Merged
Cleanup layout footer gap #10435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
requested changes
Aug 8, 2023
resources/css/bem/footer.less
Outdated
| @@ -48,6 +48,8 @@ | |||
| } | |||
|
|
|||
| .u-chat & { | |||
| margin-top: -10px; // compensate for section's margin; no scroll full screen looks weird with a gap. | |||
There was a problem hiding this comment.
I think it's not too bad 🤔
(confirmed with flyte)
| @@ -136,13 +130,15 @@ | |||
| &__section { | |||
| display: flex; | |||
| flex-direction: column; | |||
| margin-bottom: 10px; | |||
There was a problem hiding this comment.
account settings page now has 15px margin (from previously also incorrect 5px)
nanaya
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
margin-bottomgap to the section container.Apparently it's supposed to be everywhere; except it looks really odd in chat, especially on mobile, so I removed it there.