Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for multiplayer score links related table #10438

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Aug 3, 2023

Just the migration because the spectator server will need to be updated to also query the new table.

Not sure if ScoreLink class name makes sense 🤔

Will be used by #10437.

Todo:

Migrations:

  • 2023_08_25_000000_create_multiplayer_score_links (just new table, should be fine run as is)
  • 2023_08_25_000001_add_score_link_id_to_multiplayer_scores_high
    alter table `multiplayer_scores_high` add `score_link_id` bigint unsigned null after `score_id`
    alter table `multiplayer_scores_high` add index `top_scores_linked`(`playlist_item_id`, total_score DESC, `score_link_id`)
    
  • 2023_08_25_000002_add_last_score_link_id_to_multiplayer_rooms_high
    alter table `multiplayer_rooms_high` add `last_score_link_id` bigint unsigned null after `last_score_id`
    

notbakaneko
notbakaneko previously approved these changes Aug 24, 2023
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine 👀

@nanaya
Copy link
Collaborator Author

nanaya commented Aug 24, 2023

wait, I guess I should redate the migrations here 🤔

@peppy peppy self-assigned this Aug 25, 2023
@nanaya nanaya enabled auto-merge August 25, 2023 09:14
@nanaya nanaya merged commit 7dad1ba into ppy:master Aug 25, 2023
3 checks passed
@nanaya nanaya deleted the mp-solo-link-migration branch December 19, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants