Enforce string query and mode search params #10462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure to not trim nulls.
notbakaneko
reviewed
Aug 17, 2023
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| <a | |||
| class="search-result__more-button {{ $showMore ? '' : 'search-result__more-button--hidden' }}" | |||
| href="{{ route('search', ['mode' => $mode, 'query' => request('query')]) }}" | |||
There was a problem hiding this comment.
I remember this being done intentionally to preserve the query as-is instead of changing foo to foo but I suppose it should be fine as long as the input box's text itself isn't changing 🤔
notbakaneko
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure to not trim nulls.
(this is mainly to not throw error when
queryparameter is an array)