Update to Typescript 5 #10535
Merged
Update to Typescript 5 #10535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nanaya
requested changes
Sep 11, 2023
resources/js/models/chat/channel.ts
Outdated
| @@ -295,7 +295,9 @@ export default class Channel { | |||
|
|
|||
| runInAction(() => { | |||
| // gap in messages, just clear all messages instead of dealing with the gap. | |||
| const minMessageId = minBy(messages, 'messageId')?.messageId ?? -1; | |||
| const maybeMinMessageId = minBy(messages, 'messageId')?.messageId ?? -1; | |||
| @@ -50,7 +50,11 @@ export default class ConversationView extends React.Component<Props> { | |||
| each(channel.messages, (message: Message, key: number) => { | |||
| // check if the last read indicator needs to be shown | |||
| // when messageId is a uuid, comparison will always be false. | |||
There was a problem hiding this comment.
this comment can use an update
resources/js/models/chat/channel.ts
Outdated
| @@ -295,7 +295,9 @@ export default class Channel { | |||
|
|
|||
| runInAction(() => { | |||
| // gap in messages, just clear all messages instead of dealing with the gap. | |||
| const minMessageId = minBy(messages, 'messageId')?.messageId ?? -1; | |||
| const maybeMinMessageId = minBy(messages, 'messageId')?.messageId ?? -1; | |||
| // for typing; realistically, a uuid won't be min unless it's the only value. | |||
There was a problem hiding this comment.
or is it 🤔
> _.minBy([{a:'100asd'},{a:100}], 'a')
Object { a: "100asd" }
first item being a string turned it into a string comparison
nanaya
requested changes
Sep 11, 2023
resources/js/models/chat/channel.ts
Outdated
Comment on lines
18
to
20
| return typeof message.messageId === 'number' | ||
| ? message.messageId | ||
| : NaN; |
There was a problem hiding this comment.
might as well make a normal loop?
let ret: number|undefined;
for (const m of messages) {
if (typeof m.messageId === 'number' && (ret == null || m.messageId < ret)) {
ret = m.messageId;
}
}
return ret ?? -1;also add note about fixing/checking getter and variable names
|
conflicts |
nanaya
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't break anything, hopefully 🤔