Improve UI performance of long chat channel lists #10631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Oct 12, 2023
| return ( | ||
| <React.Fragment key={type}> | ||
| <div className='chat-conversation-list__group'> | ||
| <div className='chat-conversation-list__header'> | ||
| <span className='chat-conversation-list__header-text'>{title}</span> | ||
| <span className='chat-conversation-list__header-icon' title={title}><i className={icons[type]} /></span> | ||
| </div> | ||
| {channels.map((channel) => <ConversationListItem key={channel.channelId} channel={channel} />)} | ||
| {chunks.map((c, index) => ( |
There was a problem hiding this comment.
Might be worth adding a comment somewhere in here mentioning that this is an optimisation.
nanaya
requested changes
Oct 26, 2023
nanaya
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of long channel lists especially on Safari; slight improvement on Chrome but nowhere near the same extent as Safari.
The channel list is broken down into channel chunks so that each chunk can be it's own render layer; 100 (arbitrary) seems to be a reasonable size - too big and Safari's performance takes a dive, too small creates too many layers...and Safari's performance also takes a steep dive. (edit: too many layers causes too many layout recalculations even it their content doesn't change, and layout is relatively expensive compared to re-rendering)
React-keyed elements ending up in different chunks when the list changes shouldn't be an issue since the list usually gets rearranged at that point.