Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forum topic cover handling #11227

Merged
merged 4 commits into from
May 24, 2024
Merged

Fix forum topic cover handling #11227

merged 4 commits into from
May 24, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented May 23, 2024 •
edited
Loading

Resolves #11226.

  • incorrect cover file check
  • missing topic id on relevant model

@cl8n
Copy link
Member

cl8n commented May 23, 2024 •
edited
Loading

can still reproduce part of the issue by:

  1. make a new post
  2. upload a topic cover (using the edit cover button)
  3. refresh page

viewing, deleting, and editing existing cover all works 👍

@nanaya @cl8n
Adjust comment
271fefd 
Co-authored-by: clayton <[email protected]>
@nanaya nanaya changed the title Fix existence check for topic cover Fix forum topic cover handling May 24, 2024
@notbakaneko notbakaneko merged commit 24c659c into ppy:master May 24, 2024
3 checks passed
@nanaya nanaya deleted the topic-cover branch July 26, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

@cl8n cl8n cl8n approved these changes

Assignees
No one assigned
Labels
area:forum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topic covers not viewable or editable
3 participants
@nanaya @cl8n @notbakaneko