Put back announcement channel user listing #11518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
requested changes
Oct 2, 2024
Comment on lines
+271
to
+274
| {users == null ? ( | ||
| <> | ||
| <Spinner modifiers='self-center' /><span>{trans('chat.loading_users')}</span> | ||
| </> |
There was a problem hiding this comment.
I think we can just skip trying to load users if they don't have permission to view it anyway.
Or maybe return users: [] with the channel if they have no permission to load users and null otherwise 🤔 (or both)
There was a problem hiding this comment.
I'll look into that... eventually...
probably not changing existing json fields though.
notbakaneko
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with limit.
The user loading flash for those with no listing permission gets a bit worse here but I think fixing it should be a different PR 🤔added additional priv attribute to check if it should load user list(or maybe someone can come up with better design)