Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust dashboard banner position #11537

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Oct 8, 2024

The glow is kinda intentional 👀

peppy
peppy previously approved these changes Oct 8, 2024
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through design changes IRL 👍 Better than what we have live so let's get this out and then work forward from there.

@notbakaneko
Copy link
Collaborator

Is the glow supposed to bleed everywhere?

@nanaya
Copy link
Collaborator Author

nanaya commented Oct 8, 2024

yes

Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm
image
image
image

(also it's kind of hard to tap anything other than the banner link on mobile)

@nanaya
Copy link
Collaborator Author

nanaya commented Oct 8, 2024

yeah I'm not sure why the indicator button isn't clickable on the content padding area ಠ_ಠ

@notbakaneko notbakaneko merged commit 8a1ef75 into ppy:master Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants