Add account setting to link GitHub account #9465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not very useful...
nanaya
requested changes
Dec 8, 2022
|
oh right I forgot I broke legacy changelog too. i will fix that tomorrow 💤 |
basically revert some of the code that assumed GitHub username would never be null.
|
... I had a long day 😅 I reverted some of the changes I made to the |
nanaya
requested changes
Jun 26, 2023
|
|
||
| abort_if($user === null, 422, osu_trans('accounts.github_user.error.no_contribution')); | ||
|
|
||
| abort_if($user->user_id !== null, 422, osu_trans('accounts.github_user.error.already_linked')); |
There was a problem hiding this comment.
can use also check if there's existing github user for the user id
There was a problem hiding this comment.
that check happens in create()
|
@cl8n is this ready for re-review? |
nanaya
requested changes
Sep 20, 2023
database/migrations/2023_09_12_230000_require_github_users_id_and_username.php
Outdated
Show resolved
Hide resolved
database/migrations/2023_09_12_230000_require_github_users_id_and_username.php
Outdated
Show resolved
Hide resolved
and an attempt to make it easier to read
nanaya
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so open source contributors can link themselves on changelogs