Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to disable Taiko notes flying after hit #31665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aedoq
Copy link

@aedoq aedoq commented Jan 24, 2025

In osu!stable, the "flying away" animation is shown only when the HUD is active. This adds a configuration option to restore this behaviour or to disable the animation altogether.

Discussed previously: #23656

@aedoq
Copy link
Author

aedoq commented Jan 24, 2025

Short demo:

taiko_demo.mp4

@LittleLilyBun
Copy link

Just a personal opinion as a taiko player, I like this but it feels like the fade effect takes too long, I feel like I'm hitting late because the note disappears late. For comparison, stable faded the notes instantly.

In osu!stable, the "flying away" animation is shown only when the HUD
is active. This adds a configuration option to restore this behaviour
or to disable the animation altogether.
@aedoq aedoq force-pushed the hit-flying-config branch from ae0515c to ef45c1d Compare January 24, 2025 22:05
@aedoq
Copy link
Author

aedoq commented Jan 24, 2025

@LittleLilyBun You're right, I changed this to be the same as in stable, should be less jarring:

2025-01-24.23-07-48.mp4

@OpenSauce04
Copy link
Contributor

As an aside, I made a somewhat related pull request about a year ago addressing the animation of the flying notes not snapping to the center of the judgement area like they do in stable: #26926

Perhaps these two features could be combined together into a single setting as they both relate to the appearance of the flying notes?

Would wait on the thoughts of a maintainer before making any changes.

@smoogipoo
Copy link
Contributor

I'm not going to make a call on this one because this is something that would've been addressed by ruleset skinning. Will defer to @peppy.

@smoogipoo smoogipoo requested a review from peppy January 27, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants