Fixed User Ruleset from Leaderboard

[Ianlucht]

Made a user profile open to the desired ruleset from a beatmap rather than the profile ruleset at all times.

Resolves #31628

[Ianlucht]

Alright, I made the changes, but now there is a dependency issue in , and I have no idea how to fix this issue. osu.Framework.Allocation.DependencyNotRegisteredException: The type LeaderboardScore has a dependency on OsuGame, but the dependency is not registered. I had to add the private OsuGame = game there to be able to get the correct user profile up with the ruleset, but in adding that it seems to have broken the dependencies there. I don't know how to properly register it. I thought I just had to add it the way it was added to ClickableAvatar, but that seems incorrect.

[Ianlucht]

Trying to figure out a way to have the nullable OsuGame reference where the other references are explicitly un-nullable

[bdach]

Please squash and force-push all of the extra commits out of here, it's noise in history that doesn't need to be there.

Upon closer inspection this should probably also be applied to clickable avatars on the results screen:

which is going to be a bit annoying to achieve and also makes me unsure about whether this change is worth it in general.

[bdach]

That's not how this should be done. Old classes where NRT is still not on are a bit of an edge case.

diff --git a/osu.Game/Online/Leaderboards/LeaderboardScore.cs b/osu.Game/Online/Leaderboards/LeaderboardScore.cs
index 2f8e7bb7b9..438a0e2268 100644
--- a/osu.Game/Online/Leaderboards/LeaderboardScore.cs
+++ b/osu.Game/Online/Leaderboards/LeaderboardScore.cs
@@ -6,6 +6,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using JetBrains.Annotations;
 using osu.Framework.Allocation;
 using osu.Framework.Extensions.Color4Extensions;
 using osu.Framework.Graphics;
@@ -87,11 +88,9 @@ public partial class LeaderboardScore : OsuClickableContainer, IHasContextMenu,
         [Resolved]
         private ScoreManager scoreManager { get; set; } = null!;
 
-        // using nullable enable here because canBeNull is not respected for OsuGame
-#nullable enable
-
-        [Resolved]
-        private OsuGame? game { get; set; }
+        [Resolved(CanBeNull = true)]
+        [CanBeNull]
+        private OsuGame game { get; set; }
 
         public LeaderboardScore(ScoreInfo score, int? rank, bool isOnlineScope = true, bool highlightFriend = true)
         {