Add percent progress display to editor footer #31841
Merged
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peppy
commented
Feb 10, 2025
peppy
commented
bdach
approved these changes
Feb 10, 2025
|
|
||
| protected override void Update() | ||
| { | ||
| base.Update(); | ||
|
|
||
| double newBPM = editorBeatmap.ControlPointInfo.TimingPointAt(editorClock.CurrentTime).BPM; | ||
| double newProgress = (int)(editorClock.CurrentTime / editorClock.TrackLength * 100); |
There was a problem hiding this comment.
Not sure on this doing flooring, but it appears to match SongProgressInfo, and also does seem reach 100% at some point, so probably fine
| if (lastProgress != newProgress) | ||
| { | ||
| lastProgress = newProgress; | ||
| progress.Text = @$"{newProgress:0}%"; |
There was a problem hiding this comment.
This also probably has localisation concerns, but so does the rest of the editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.