Fix spectator list showing other users in multiplayer room even if they're not spectating #31844
+54
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Would close #31819.
Very ad-hoc fix (see relevant inline comment), but also simple, and I'd rather start simple and only escalate complexity as required.
No test coverage for two reasons: (a) I'm unsure if this will survive at least a quick review, (b) testing anything that touches
MultiplayerClientoutside of the nice test scenes with all the nice setup is like hours lost to setting everything up just right - that said, I will add tests on request.