Don't include config.h or params.h directly

mlkem-native's source and header files should instead include `common.h`. This commit fixes a few header and source files in this regard. Signed-off-by: Hanno Becker <[email protected]>
pq-code-package · Jan 6, 2025 · 7f621d2 · 7f621d2
1 parent f3029dd
commit 7f621d2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/mlkem/fips202/keccakf1600.c b/mlkem/fips202/keccakf1600.c
@@ -10,14 +10,12 @@
  * from https://twitter.com/tweetfips202
  * by Gilles Van Assche, Daniel J. Bernstein, and Peter Schwabe */
 
-#include "keccakf1600.h"
 #include <assert.h>
 #include <stdint.h>
 
-#include "config.h"
-#include "fips202_backend.h"
-
 #include "cbmc.h"
+#include "fips202_backend.h"
+#include "keccakf1600.h"
 
 #define NROUNDS 24
 #define ROL(a, offset) ((a << offset) ^ (a >> (64 - offset)))

diff --git a/mlkem/kem.h b/mlkem/kem.h
@@ -7,7 +7,7 @@
 
 #include <stdint.h>
 #include "cbmc.h"
-#include "params.h"
+#include "commmon.h"
 
 #define CRYPTO_SECRETKEYBYTES MLKEM_SECRETKEYBYTES
 #define CRYPTO_PUBLICKEYBYTES MLKEM_PUBLICKEYBYTES

diff --git a/mlkem/polyvec.c b/mlkem/polyvec.c
@@ -5,7 +5,6 @@
 #include "polyvec.h"
 #include <stdint.h>
 #include "arith_backend.h"
-#include "config.h"
 #include "ntt.h"
 #include "poly.h"
 

diff --git a/mlkem/verify.h b/mlkem/verify.h
@@ -9,7 +9,7 @@
 #include <stddef.h>
 #include <stdint.h>
 #include "cbmc.h"
-#include "params.h"
+#include "common.h"
 
 /* Static namespacing
  * This is to facilitate building multiple instances