No static code scan

.github/workflows/e2e-default-flags.yml → .github/workflows/e2e-express.yml

@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [20.x]
         # Uncomment and replace with current `os` when windows-run bug is fixed
         # os: [ubuntu-latest, windows-latest]
         os: [ubuntu-latest]
@@ -32,7 +32,7 @@ jobs:
       - run: npm ci
 
       - name: Test
-        run: npm t -- --collectCoverage e2e
+        run: npm t -- e2e-express
 
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3

.github/workflows/e2e-fastify.yml

@@ -0,0 +1,45 @@
+name: generator-e2e
+
+on:
+  push:
+    branches:
+      - "*"
+  pull_request:
+    branches: [main]
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        node-version: [20.x]
+        # Uncomment and replace with current `os` when windows-run bug is fixed
+        # os: [ubuntu-latest, windows-latest]
+        os: [ubuntu-latest]
+
+    env:
+      OS: ${{ matrix.os }}
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          cache: "npm"
+          node-version: ${{ matrix.node-version }}
+
+      - run: npm ci
+
+      - name: Test
+        run: npm t -- e2e-fastify
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v3
+        with:
+          directory: ./test-reports/coverage
+          env_vars: OS
+          fail_ci_if_error: true
+          flags: generator
+          name: codecov-umbrella
+          verbose: true

.github/workflows/security.yml

@@ -24,14 +24,6 @@ jobs:
           command: test
           args: --all-projects --severity-threshold=critical --sarif-file-output=~/sarif/sca.sarif
 
-      - name: Run Snyk Static Code Analysis
-        uses: snyk/actions/node@master
-        env:
-          SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
-        with:
-          command: code test
-          args: --severity-threshold=high --sarif-file-output=~/sarif/sast.sarif
-
       - name: list
         run: "ls -a ~/sarif"
 

src/code-templates/services/order-service/entry-points-fastify/api/routes.ts

@@ -41,6 +41,7 @@ export async function routes(app: FastifyWithTypeProvider) {
       }),
     },
     handler: async (request, response) => {
+      // Validation runs before the handler, request.params.id must be a number
       logger.info(`Order API was called to get order by id`, {
         orderId: request.params.id,
       });