chore: docker #254
chore: docker #254
Conversation
Codecov ReportBase: 90.92% // Head: 90.92% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 16 16
Lines 595 595
Branches 43 43
=======================================
Hits 541 541
Misses 53 53
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Great job!
For large applications I think we should not do that as you lose the advantage of different services moving at a different pace and every change even if not related to production code (e.g updating some dev dependency with breaking change) will force you to change everywhere
Care to explain why? |
| COPY package-lock.json /app/ | ||
| COPY package-lock.json /app/ | ||
| RUN npm ci --only=production | ||
| RUN npm install turbo -g |
There was a problem hiding this comment.
This can potentially install a version that is different from the version in the package.json and may work differently if it has some breaking changes
FYI, if it has cache it will not install the turbo package even if there is some security fix for example
The 2nd point is ok as when deploying we should not have docker cache (90% sure for Github Actions)
'*'instead to a specific versionpackage-lockfiles, except for rootThis PR doesn't handle
productionbuild - dev dependencies stay inside the docker, also source TS code.(Also, need to review devDeps for all libraries, I believe some are wrong).