Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove launcher #8

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Refactor/remove launcher #8

merged 2 commits into from
Mar 21, 2022

Conversation

JulianFeinauer
Copy link
Contributor

refactor: remove launcher pseudo-app

Removes launcher pseudo app and solely relies on omap.py to start the platform

Removes launcher pseudo app and solely relies on omap.py to start the platform
@NiklasMerz
Copy link
Member

@JulianFeinauer I rebased it to fix the conflict. Now the CI is broken. You probably know what to do.

@JulianFeinauer
Copy link
Contributor Author

@NiklasMerz the issue is indeed a valid one.
Its pytest_django crashing because I removed the settings.py file.
So to be able to use pytest django with the "omap" construction we need a slightly patched version of pytest_django, I guess...

@JulianFeinauer
Copy link
Contributor Author

@NiklasMerz I opened an issue on pytest-django, that would solve the problem for us: pytest-dev/pytest-django#1001

@JulianFeinauer
Copy link
Contributor Author

@NiklasMerz you see a demo implementaton here: pytest-dev/pytest-django#1002
And this is how the code would need to be modified to work, if the PR above would be merged: https://github.com/pragmaticindustries/open-machine-plattform/tree/feature/new-launcher-with-pytest-fixes

@JulianFeinauer
Copy link
Contributor Author

@NiklasMerz thanks to your hint its green again now : )

@NiklasMerz NiklasMerz merged commit d5038da into develop Mar 21, 2022
@NiklasMerz NiklasMerz deleted the refactor/remove-launcher branch March 21, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants