🐛 If all conditions are filtered out, don't add the rule (konveyor#291)

Closes konveyor#289

Signed-off-by: Fabian von Feilitzsch <[email protected]>

parser/rule_parser.go

@@ -610,6 +610,11 @@ func (r *RuleParser) getConditions(conditionsInterface []interface{}) ([]engine.
 				if err != nil {
 					return nil, nil, err
 				}
+				// There was no error so the conditions have all been filtered
+				// Return early to prevent constructing an empty rule
+				if len(conds) == 0 && len(conds) != len(iConditions) {
+					return []engine.ConditionEntry{}, nil, nil
+				}
 				ce = engine.ConditionEntry{
 					From:      from,
 					As:        as,
@@ -631,6 +636,11 @@ func (r *RuleParser) getConditions(conditionsInterface []interface{}) ([]engine.
 				if err != nil {
 					return nil, nil, err
 				}
+				// There was no error so the conditions have all been filtered
+				// Return early to prevent constructing an empty rule
+				if len(conds) == 0 && len(conds) != len(iConditions) {
+					return []engine.ConditionEntry{}, nil, nil
+				}
 				ce = engine.ConditionEntry{
 					From:      from,
 					As:        as,