🐛 respect match-all label values

Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad · Feb 7, 2024 · b43893a · b43893a
1 parent 61fce08
commit b43893a
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/engine/labels/labels.go b/engine/labels/labels.go
@@ -261,7 +261,7 @@ func tokenize(expr string) []string {
 
 func matchesAny(elem string, items []string) bool {
 	for _, item := range items {
-		if labelValueMatches(item, elem) {
+		if item == "" || labelValueMatches(item, elem) {
 			return true
 		}
 	}

diff --git a/engine/labels/labels_test.go b/engine/labels/labels_test.go
@@ -386,6 +386,33 @@ func Test_ruleSelector_Matches(t *testing.T) {
 			},
 			want: false,
 		},
+		{
+			name: "rule has a match-all source label",
+			expr: "konveyor.io/target=t1 && konveyor.io/source=t2",
+			ruleLabels: []string{
+				"konveyor.io/target=t1",
+				"konveyor.io/source",
+			},
+			want: true,
+		},
+		{
+			name: "rule has a specific source label",
+			expr: "konveyor.io/target=t1 && konveyor.io/source=t2",
+			ruleLabels: []string{
+				"konveyor.io/target=t1",
+				"konveyor.io/source=t3",
+			},
+			want: false,
+		},
+		{
+			name: "query contains match-all label",
+			expr: "konveyor.io/target=t1 && konveyor.io/source",
+			ruleLabels: []string{
+				"konveyor.io/target=t1",
+				"konveyor.io/source=t3",
+			},
+			want: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {