Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add some types to router, rename a couple vars #32

Merged
merged 1 commit into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
},
"files": [
"src",
"!src/internal.d.ts",
"LICENSE",
"package.json",
"README.md"
Expand Down
15 changes: 15 additions & 0 deletions src/internal.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
export interface AugmentedComponent extends Component<any, any> {
__v: VNode;
__c: (error: Promise<void>, suspendingVNode: VNode) => void;
}

export interface VNode<P = any> extends preact.VNode<P> {
__c: AugmentedComponent;
__e?: Element | Text;
__u: number;
__h: boolean;
__v?: VNode<P>;
__k: Array<VNode<any>> | null;
}

export {}
5 changes: 3 additions & 2 deletions src/router.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@ interface LocationHook {
}
export const useLocation: () => LocationHook;

export const useRoute: () => {
interface RouteHook {
path: string;
query: Record<string, string>;
params: Record<string, string>;
};
}
export const useRoute: () => RouteHook;

interface RoutableProps {
path?: string;
Expand Down
41 changes: 26 additions & 15 deletions src/router.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import { h, createContext, cloneElement, toChildArray } from 'preact';
import { useContext, useMemo, useReducer, useLayoutEffect, useRef } from 'preact/hooks';

/**
* @template T
* @typedef {import('preact').RefObject<T>} RefObject
* @typedef {import('./internal.d.ts').VNode} VNode
*/

let push;
const UPDATE = (state, url) => {
push = undefined;
Expand Down Expand Up @@ -96,6 +102,7 @@ export function LocationProvider(props) {
}

const RESOLVED = Promise.resolve();
/** @this {import('./internal.d.ts').AugmentedComponent} */
export function Router(props) {
const [c, update] = useReducer(c => c + 1, 0);

Expand All @@ -107,27 +114,28 @@ export function Router(props) {
// Monotonic counter used to check if an un-suspending route is still the current route:
const count = useRef(0);
// The current route:
const cur = useRef();
const cur = /** @type {RefObject<VNode<any>>} */ (useRef());
// Previous route (if current route is suspended):
const prev = useRef();
const prev = /** @type {RefObject<VNode<any>>} */ (useRef());
// A not-yet-hydrated DOM root to remove once we commit:
const pendingBase = useRef();
const pendingBase = /** @type {RefObject<Element | Text>} */ (useRef());
// has this component ever successfully rendered without suspending:
const hasEverCommitted = useRef(false);
// was the most recent render successful (did not suspend):
const didSuspend = useRef();
const didSuspend = /** @type {RefObject<boolean>} */ (useRef());
didSuspend.current = false;
// has the route component changed
const routeChanged = useRef(false);

let pr, d, m;
toChildArray(props.children).some(vnode => {
const matches = exec(rest, vnode.props.path, (m = { ...vnode.props, path: rest, query, params, rest: '' }));
if (matches) return (pr = cloneElement(vnode, m));
if (vnode.props.default) d = cloneElement(vnode, m);
let pathRoute, defaultRoute, matchProps;
toChildArray(props.children).some((/** @type {VNode<any>} */ vnode) => {
const matches = exec(rest, vnode.props.path, (matchProps = { ...vnode.props, path: rest, query, params, rest: '' }));
if (matches) return (pathRoute = cloneElement(vnode, matchProps));
if (vnode.props.default) defaultRoute = cloneElement(vnode, matchProps);
});

let incoming = pr || d;
/** @type {VNode<any> | undefined} */
let incoming = pathRoute || defaultRoute;
useMemo(() => {
prev.current = cur.current;

Expand All @@ -143,7 +151,8 @@ export function Router(props) {

const isHydratingSuspense = cur.current && cur.current.__u & MODE_HYDRATE && cur.current.__u & MODE_SUSPENDED;
const isHydratingBool = cur.current && cur.current.__h;
cur.current = h(RouteContext.Provider, { value: m }, incoming);
// @ts-ignore
cur.current = /** @type {VNode<any>} */ (h(RouteContext.Provider, { value: matchProps }, incoming));
if (isHydratingSuspense) {
cur.current.__u |= MODE_HYDRATE;
cur.current.__u |= MODE_SUSPENDED;
Expand Down Expand Up @@ -242,10 +251,12 @@ const RenderRef = ({ r }) => r.current;

Router.Provider = LocationProvider;

/** @typedef {{ url: string, path: string, query: object, route, wasPush: boolean }} RouteInfo */

LocationProvider.ctx = createContext(/** @type {RouteInfo} */ ({}));
const RouteContext = createContext({});
LocationProvider.ctx = createContext(
/** @type {import('./router.d.ts').LocationHook & { wasPush: boolean }} */ ({})
);
const RouteContext = createContext(
/** @type {import('./router.d.ts').RouteHook & { rest: string }} */ ({})
);

export const Route = props => h(props.component, props);

Expand Down