Skip to content

Commit

Permalink
MgidX Bid Adapter: refactor request.gdpr object generating (#10782)
Browse files Browse the repository at this point in the history
* new adapter - MgidX

* add new required param host

* Revert "add new required param host"

This reverts commit 3bafe78.

* refactoring generating request.gdpr object

* fix test

---------

Co-authored-by: Evgeny Nagorny <[email protected]>
Co-authored-by: xmgiddev <>
  • Loading branch information
xmgiddev and evjman authored Dec 2, 2023
1 parent 4f057b1 commit cbf1e15
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
7 changes: 6 additions & 1 deletion modules/mgidXBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,15 @@ export const spec = {
placements,
coppa: config.getConfig('coppa') === true ? 1 : 0,
ccpa: bidderRequest.uspConsent || undefined,
gdpr: bidderRequest.gdprConsent || undefined,
tmax: config.getConfig('bidderTimeout')
};

if (bidderRequest.gdprConsent) {
request.gdpr = {
consentString: bidderRequest.gdprConsent.consentString
};
}

const len = validBidRequests.length;
for (let i = 0; i < len; i++) {
const bid = validBidRequests[i];
Expand Down
13 changes: 9 additions & 4 deletions test/spec/modules/mgidXBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ describe('MGIDXBidAdapter', function () {

const bidderRequest = {
uspConsent: '1---',
gdprConsent: 'COvFyGBOvFyGBAbAAAENAPCAAOAAAAAAAAAAAEEUACCKAAA.IFoEUQQgAIQwgIwQABAEAAAAOIAACAIAAAAQAIAgEAACEAAAAAgAQBAAAAAAAGBAAgAAAAAAAFAAECAAAgAAQARAEQAAAAAJAAIAAgAAAYQEAAAQmAgBC3ZAYzUw',
gdprConsent: {
consentString: 'COvFyGBOvFyGBAbAAAENAPCAAOAAAAAAAAAAAEEUACCKAAA.IFoEUQQgAIQwgIwQABAEAAAAOIAACAIAAAAQAIAgEAACEAAAAAgAQBAAAAAAAGBAAgAAAAAAAFAAECAAAgAAQARAEQAAAAAJAAIAAgAAAYQEAAAQmAgBC3ZAYzUw',
vendorData: {}
},
refererInfo: {
referer: 'https://test.com'
}
Expand Down Expand Up @@ -131,7 +134,7 @@ describe('MGIDXBidAdapter', function () {
expect(data.host).to.be.a('string');
expect(data.page).to.be.a('string');
expect(data.coppa).to.be.a('number');
expect(data.gdpr).to.be.a('string');
expect(data.gdpr).to.be.a('object');
expect(data.ccpa).to.be.a('string');
expect(data.tmax).to.be.a('number');
expect(data.placements).to.have.lengthOf(3);
Expand Down Expand Up @@ -172,8 +175,10 @@ describe('MGIDXBidAdapter', function () {
serverRequest = spec.buildRequests(bids, bidderRequest);
let data = serverRequest.data;
expect(data.gdpr).to.exist;
expect(data.gdpr).to.be.a('string');
expect(data.gdpr).to.equal(bidderRequest.gdprConsent);
expect(data.gdpr).to.be.a('object');
expect(data.gdpr).to.have.property('consentString');
expect(data.gdpr).to.not.have.property('vendorData');
expect(data.gdpr.consentString).to.equal(bidderRequest.gdprConsent.consentString);
expect(data.ccpa).to.not.exist;
delete bidderRequest.gdprConsent;
});
Expand Down

0 comments on commit cbf1e15

Please sign in to comment.