Dailymotion Bid Adaptor: initial release #10970

kvnsw · 2024-01-22T16:23:42Z

Type of change

New bidder adapter : docs PR (prebid.github.io) -> Dailymotion Bid Adaptor: initial release prebid.github.io#5091

Description of change

A new bidder adapter dailymotionBidAdapter added.

contact email of the adapter’s maintainer : [email protected]
Test parameters for validating bids:

By setting the following configuration options, you'll get a constant response to any request to validate your adapter integration:

const adUnits = [
  {
    bids: [{
      bidder: 'dailymotion',
      params: {
        apiKey: 'dailymotion-testing'
      }
    }],
    code: 'test-ad-unit',
    mediaTypes: {
      video: {
        api: [2, 7],
        context: 'instream',
        playerSize: [ [1280, 720] ],
        startDelay: 0
      },
    }
  }
];

Dailymotion Bid Adaptor: initial release

modules/dailymotionBidAdapter.js

…lbacks

kvnsw · 2024-02-13T07:54:22Z

Hello @jlquaccia, following changes related to @dgirardi's feedback, could we have a second review? :) Thanks!

modules/dailymotionBidAdapter.md

modules/dailymotionBidAdapter.js

The same way as we can have an array of IAB categories level 1 in the ORTB request, this PR introduces an array for the IAB categories level 2. To be forward compatible with level [2.2](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%202.2.tsv) and [3.0](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%203.0.tsv) specifications, the category IDs should be sent as strings.

feat(LEO-528): Allow multiple IAB categories level 2 in video metadata

kvnsw · 2024-03-25T15:06:03Z

Hello @patmmccann, @dgirardi, @ChrisHuie,
Following our changes to address your feedback, could you please provide an additional review/validation of this PR?
Thank you!

kvnsw · 2024-04-09T13:30:24Z

Hello @patmmccann, @dgirardi, @ChrisHuie, sorry to bother, I think we have addressed all your feedbacks now and have a final submission. Please let us know if we can move forward :) Thank you!

modules/dailymotionBidAdapter.js

patmmccann · 2024-04-17T14:57:44Z

modules/dailymotionBidAdapter.js

+      config: {
+        api_key: bid.params.apiKey
+      },
+      coppa: config.getConfig('coppa'),


please get this from the request and not the confgi

modules/dailymotionBidAdapter.js

patmmccann · 2024-04-17T15:01:50Z

@kvnsw taking over this review from Karim; looking forward to working with you. Feel free to slack me

Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2

karimMourra · 2024-04-18T16:21:25Z

@patmmccann Note that the Video Taskforce had some concerns about this PR:

In an effort to simplify configuration for publishers, the Prebid Video Taskforce is requiring bid adapters to follow the oRTB spec.

mediaTypes.video should contain fields from oRTB section 3.2.7
For content specific fields, we encourage reading from site.content, see ortb 2.6 section 3.2.13

Reference: ortb 2.6 spec: https://iabtechlab.com/wp-content/uploads/2022/04/OpenRTB-2-6_FINAL.pdf](https://github.com/prebid/Prebid.js/pull/10970)

anything outside of the spec can be included in the bidder params (i.e. params.video). Though the implementation wouldn't change, we are concerned with the examples and documentation mentioning non-ortb fields in mediaTypes.video

m-gendi · 2024-04-18T17:24:19Z

Thank you @patmmccann and @karimMourra for your reviews, we appreciate it.
We will address the remaining comments in a new PR, aiming to resolve them.

* Dailymotion Bid Adaptor: initial release * .md file lint issue resolved * Dailymotion Bid Adaptor: build bidder request based on param with fallbacks * Dailymotion Bid Adaptor: support video metadata * Dailymotion Bid Adaptor: add support for sending adUnitCode * Dailymotion Bid Adaptor: add support for sending startDelay * feat(LEO-528): Allow multiple IAB categories in video metadata The same way as we can have an array of IAB categories level 1 in the ORTB request, this PR introduces an array for the IAB categories level 2. To be forward compatible with level [2.2](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%202.2.tsv) and [3.0](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%203.0.tsv) specifications, the category IDs should be sent as strings. * Dailymotion bid adapter: Clarify the video metadata to provide in each player context * Dailymotion bid adapter: Move API key to bid params * Dailymotion bid adapter: Verify API key is string Co-authored-by: Rumesh <[email protected]> * Dailymotion bid adapter: Move API key to bid params (fix tests) * Dailymotion Bid Adaptor: add gpp support and get coppa from request * Dailymotion Bid Adaptor: fix lint error * Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2 * Dailymotion Bid Adaptor: get iabcats from ortb2.site.content.data --------- Co-authored-by: Kevin Siow <[email protected]> Co-authored-by: Aditi Chaudhary <[email protected]> Co-authored-by: Sébastien Millet <[email protected]> Co-authored-by: Rumesh <[email protected]>

Dailymotion Bid Adaptor: initial release

5b534be

kvnsw mentioned this pull request Jan 22, 2024

Dailymotion Bid Adaptor: initial release prebid/prebid.github.io#5091

Merged

3 tasks

Aditi0101 and others added 2 commits January 22, 2024 17:56

.md file lint issue resolved

807c75b

Merge pull request #3 from dailymotion-oss/feat/dailymotion-adaptor

9eb2277

Dailymotion Bid Adaptor: initial release

ChrisHuie added the feature label Jan 25, 2024

ChrisHuie requested a review from jlquaccia January 25, 2024 17:50

ChrisHuie assigned jlquaccia Jan 25, 2024

dgirardi reviewed Jan 30, 2024

View reviewed changes

modules/dailymotionBidAdapter.js Outdated Show resolved Hide resolved

kvnsw mentioned this pull request Jan 31, 2024

feat/dailymotion-adaptor dailymotion-oss/Prebid.js#4

Merged

kvnsw and others added 2 commits February 1, 2024 10:04

Merge branch 'prebid:master' into master

3b3878e

Dailymotion Bid Adaptor: build bidder request based on param with fal…

6c25624

…lbacks

ChrisHuie requested review from ChrisHuie and removed request for jlquaccia February 20, 2024 23:36

ChrisHuie assigned ChrisHuie and unassigned jlquaccia Feb 20, 2024

patmmccann requested changes Feb 24, 2024

View reviewed changes

modules/dailymotionBidAdapter.md Outdated Show resolved Hide resolved

patmmccann reviewed Feb 24, 2024

View reviewed changes

modules/dailymotionBidAdapter.js Outdated Show resolved Hide resolved

Aditi0101 and others added 8 commits March 1, 2024 15:41

Dailymotion Bid Adaptor: support video metadata

9aab2ea

Merge branch 'prebid:master' into master

7ee40c4

Dailymotion Bid Adaptor: add support for sending adUnitCode

32d6391

Merge branch 'prebid:master' into master

d5542db

Dailymotion Bid Adaptor: add support for sending startDelay

ce0536c

Merge branch 'prebid:master' into master

9a97052

Merge pull request #10 from dailymotion-oss/LEO-528_multiple_iabcat2

4b78d35

feat(LEO-528): Allow multiple IAB categories level 2 in video metadata

sebmil-daily approved these changes Apr 8, 2024

View reviewed changes

karimMourra self-requested a review April 11, 2024 21:47

ChrisHuie assigned karimMourra and unassigned ChrisHuie Apr 15, 2024

ChrisHuie removed request for ChrisHuie and dgirardi April 15, 2024 17:44

kvnsw requested review from ChrisHuie and dgirardi April 17, 2024 08:21

patmmccann reviewed Apr 17, 2024

View reviewed changes

modules/dailymotionBidAdapter.js Show resolved Hide resolved

patmmccann reviewed Apr 17, 2024

View reviewed changes

patmmccann requested changes Apr 17, 2024

View reviewed changes

modules/dailymotionBidAdapter.js Show resolved Hide resolved

patmmccann assigned patmmccann and unassigned karimMourra Apr 17, 2024

kvnsw mentioned this pull request Apr 18, 2024

Dailymotion Bid Adaptor: add gpp support and get coppa from request dailymotion-oss/Prebid.js#14

Merged

Kevin Siow and others added 6 commits April 18, 2024 10:29

Dailymotion Bid Adaptor: add gpp support and get coppa from request

cc0c1bc

Merge branch 'prebid:master' into master

cc5f6ff

Dailymotion Bid Adaptor: fix lint error

fa56a41

Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2

36637e0

Merge pull request #16 from dailymotion-oss/dailymotion_iabcat

cff7c34

Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2

Dailymotion Bid Adaptor: get iabcats from ortb2.site.content.data

50dda1f

kvnsw requested a review from patmmccann April 18, 2024 15:37

patmmccann approved these changes Apr 18, 2024

View reviewed changes

patmmccann merged commit 08ac74f into prebid:master Apr 18, 2024
2 of 3 checks passed

sebmil-daily mentioned this pull request Apr 19, 2024

Dailymotion Bid Adapter: accept ortb2 field #11366

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dailymotion Bid Adaptor: initial release #10970

Dailymotion Bid Adaptor: initial release #10970

kvnsw commented Jan 22, 2024 •

edited

Loading

kvnsw commented Feb 13, 2024

kvnsw commented Mar 25, 2024

kvnsw commented Apr 9, 2024

patmmccann Apr 17, 2024

patmmccann commented Apr 17, 2024

karimMourra commented Apr 18, 2024

m-gendi commented Apr 18, 2024 •

edited

Loading

Dailymotion Bid Adaptor: initial release #10970

Dailymotion Bid Adaptor: initial release #10970

Conversation

kvnsw commented Jan 22, 2024 • edited Loading

Type of change

Description of change

kvnsw commented Feb 13, 2024

kvnsw commented Mar 25, 2024

kvnsw commented Apr 9, 2024

patmmccann Apr 17, 2024

Choose a reason for hiding this comment

patmmccann commented Apr 17, 2024

karimMourra commented Apr 18, 2024

m-gendi commented Apr 18, 2024 • edited Loading

kvnsw commented Jan 22, 2024 •

edited

Loading

m-gendi commented Apr 18, 2024 •

edited

Loading