Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vidazoo lib and associated bid adapters: Add ORTB2 device data to request payload #12074

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jwrosewell
Copy link
Contributor

Type of change

  • Feature
  • Updated bidder adapter

Description of change

This PR enhances bid requests formed within Vidazoo library by incorporating device data from the global ORTB2 object.

The device object has previously been populated by simplistic parsers, if at all, and was inaccurate as a result. Prebid now benefits from RTD modules such as 51Degrees that enrich all the device object fields including Apple iPhone model category and device ID. The PR enables users of Vidazoo and Vidazoo-dependent bid adapters to benefit from the device object.

Affected bid adapters:

Other information

cc: @uditalias, @saar120

@patmmccann
Copy link
Collaborator

patmmccann commented Sep 25, 2024

This needs some work, as there is now redundant logic building the request

Eg

const sua = deepAccess(bidderRequest, 'ortb2.device.sua');

# Conflicts:
#	libraries/vidazooUtils/bidderUtils.js
#	test/spec/modules/twistDigitalBidAdapter_spec.js
#	test/spec/modules/vidazooBidAdapter_spec.js
@jwrosewell jwrosewell marked this pull request as ready for review September 27, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants