Prebid Core: refactor to targeting file for readability and efficiency #12273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tread carefully! This PR adds 4 linter warnings (possibly disabled through directives):
|
patmmccann
changed the title
mmoschovas
force-pushed
the
refactor-set-targeting
branch
from
c07bbde
to
73cf3b3
Compare
|
Tread carefully! This PR adds 4 linter warnings (possibly disabled through directives):
|
|
fixes #3308 |
patmmccann
reviewed
Sep 26, 2024
patmmccann
reviewed
Sep 26, 2024
patmmccann
reviewed
Sep 26, 2024
mmoschovas
force-pushed
the
refactor-set-targeting
branch
3 times, most recently
from
968b2f3
to
8629bfa
Compare
mmoschovas
force-pushed
the
refactor-set-targeting
branch
from
8629bfa
to
541278e
Compare
dgirardi
reviewed
Sep 26, 2024
mmoschovas
force-pushed
the
refactor-set-targeting
branch
from
b783214
to
09b7e2a
Compare
|
Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):
|
mmoschovas
force-pushed
the
refactor-set-targeting
branch
from
09b7e2a
to
19a801e
Compare
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
mmoschovas
force-pushed
the
refactor-set-targeting
branch
from
19a801e
to
711d309
Compare
dgirardi
approved these changes
Sep 30, 2024
mmoschovas
added
the
needs 2nd review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Refactoring of targeting methods to improve readability, align winning bids, and implement efficiency benefits/overall loop reduction
Other information