-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showheroes Bid Adapter : full rework of the adapter #12283
Open
FilipStamenkovic
wants to merge
20
commits into
prebid:master
Choose a base branch
from
showheroes:showheroes_bidder_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Showheroes Bid Adapter : full rework of the adapter #12283
FilipStamenkovic
wants to merge
20
commits into
prebid:master
from
showheroes:showheroes_bidder_update
+299
−1,026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilipStamenkovic
force-pushed
the
showheroes_bidder_update
branch
from
September 30, 2024 12:59
52c1e16
to
489d117
Compare
This was referenced Sep 30, 2024
ChrisHuie
changed the title
Showheroes bid adapter: full rework of the adapter
Showheroes Bid Adapter : full rework of the adapter
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update the
showheroes-bs
bidder adapter.PR has the following updates:
prebid-sh
with the newopenrtb2/auction
ortbConverter
to construct a bid requestfpd
,floor
module,eids
, etc.To test the upgrade just set the openRTB request as a test request:
Other information