Skip to content

Commit

Permalink
Update external-scalers to reflect the fact that metric target type i…
Browse files Browse the repository at this point in the history
…s `averageValue` (kedacore#271)

Signed-off-by: Noorain YourTechBud <[email protected]>

* Apply suggestions from code review

Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: YourTechBud <[email protected]>

Co-authored-by: Tom Kerkhove <[email protected]>
  • Loading branch information
YourTechBud and tomkerkhove authored Oct 21, 2020
1 parent d3552d1 commit a84fb6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion content/docs/2.0/concepts/external-scalers.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ The `Scaler` interface defines 4 methods:
- `GetMetricSpec` returns the target value for the HPA definition for the scaler. For more details refer to [Implementing `GetMetricSpec`](#5-implementing-getmetricspec)
- `GetMetrics` returns the value of the metric refered to from `GetMetricSpec`. For more details refer to [Implementing `GetMetrics`](#6-implementing-getmetrics)

> Refer to the [HPA docs](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/) for how HPA calculates replicaCount based on metric value and target value.
> Refer to the [HPA docs](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/) for how HPA calculates `replicaCount` based on metric value and target value. KEDA uses the metric target type `AverageValue` for external metrics. This will cause the metric value returned by the external scaler to be divided by the number of replicas.
The `PushScaler` interface adds `Run` method. The `Run` method receives a push channel (`active`), that the scaler can push `true` to any time to force scaling action independently from `pollingInterval`.

Expand Down

0 comments on commit a84fb6c

Please sign in to comment.