fix argument handling and trimming of GITHUB_REF (#51)

prescottprue · Dec 4, 2019 · 4264801 · 4264801
1 parent d1ee3dd
commit 4264801
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -93,8 +93,9 @@ jobs:
       - name: Semantic Release
         id: semantic   # Need an `id` for output variables
         uses: cycjimmy/semantic-release-action@v2
-        extra_plugins: |
-          @jedmao/semantic-release-npm-github-config
+        with:
+          extra_plugins: |
+            @jedmao/semantic-release-npm-github-config
         env:
           GH_TOKEN: ${{ secrets.GH_TOKEN }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

diff --git a/README.md b/README.md
@@ -6,7 +6,6 @@
 [![Build Status][build-status-image]][build-status-url]
 [![Dependency Status][daviddm-image]][daviddm-url]
 [![Code Coverage][coverage-image]][coverage-url]
-
 [![License][license-image]][license-url]
 [![semantic-release][semantic-release-icon]][semantic-release-url]
 [![Code Style][code-style-image]][code-style-url]

diff --git a/src/utils/ci.js b/src/utils/ci.js
@@ -16,7 +16,8 @@ function branchNameForGithubAction() {
   }
   // GITHUB_REF for commits (i.e. refs/heads/master)
   if (GITHUB_REF) {
-    return GITHUB_REF.split('/')[2]
+    // replace is used in-case the value is passed and does not contain refs/heads/
+    return GITHUB_REF.replace('refs/heads/', '')
   }
 }
 
@@ -67,7 +68,7 @@ export function getProjectName(opts) {
   return get(
     firebaserc,
     `projects.${projectKey}`,
-    get(firebaserc, 'projects.master')
+    get(firebaserc, 'projects.master', get(firebaserc, 'projects.default'))
   )
 }