-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add split explorer to NERDTree #1389
Conversation
Hi, I appreciate your kind words and more than that I appreciate this PR, it was something I thought of doing in the past few weeks, And I'm so happy to see that somebody else stepped up to implement it. Your PR by itself is completely fine in my opinion but I've found a few quirks in the This function is being used for replacing the current directory buffer which can not be modified so this wasn't an issue until now. On the other hand, we are moving away from the previous versioning and going towards automated changelogs via Conventional Commits and multi-bulletin patches, So there is no need for editing the CHANGELOG and I would be grateful if you revert it. The final merge commit message is going to be used to write the changelogs. Let me know if you like to work on tracking this and other possible issues with this new use of CreateWindowTree. PS: In your fashion, I also would like to give a shoutout to @alerque who despite his busy schedule has always spent some time reviewing changes to this project. (edit: I just want to add to my gif, It could be fixable via checking the current buffer, If it is a file we should create a new buffer instead of replacing the current one) |
Thank you for the quick response! I see now that #1237 used |
In my opinion, since the changes are pretty relevant to the feature itself, It is appropriate to include them in this PR. |
I don't have much time to review this but a cursory glance looks like things are going in the right direction from what I know. Don't hesitate to run with things @rzvxa. I was especially keeping an eye on things early on to get you rolling and your PRs so there were two pairs of eyes on things, but in this case helping another contributor between you you are two pairs of eyes on this already. I'll still pitch in where I can, but don't wait for me. |
Hi @alerque, like @rzvxa already mentioned, thank you for your sign off and continued support on this plugin! It is cool to be a small part of the collaboration that can happen on these open source projects. @rzvxa, I created a new function to avoid having to mess with the underlying function and fixing any changes that might be needed for other dependent functions. The split on a modified buffer addresses the situation you mentioned and we are still able to leverage the 'CreateWindowTree' function. Please let me know if you have any concerns. Thank you! |
…om modified buffer
autowriteall settings
54059b6
to
d6fc841
Compare
Description of Changes
This adds a new user defined command
NERDTreeExplorer
to a split explorer for a directory.Motivation
I toggle NERDTree often after opening my file, so I tend to already use it more as an explorer than a drawer. I saw #1237 for adding split explorer had a pending action item, so I decided to implement it since it was a simple add when implemented as a command.
I also want to give a quick shout out to @rzvxa for taking the initiative to handling the majority of these most recent PRs since Phil's retirement. It's cool to see a tool live on even when it is very robust and there is not a bunch of changes happening. Thanks to you and everybody for continuing to support this tool and preventing bit rot into it! 😁