Skip to content

Commit

Permalink
update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
mfridman committed Oct 19, 2024
1 parent 1e26652 commit 8f6abb6
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions provider_options.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,7 @@ func WithDisableVersioning(b bool) ProviderOption {
})
}

// WithLogger set the logger, same behavior as with goose.SetLogger(logger)
// Using Provider would block the ability to override the logger, which could become painful to have a proper
// structured logging. By Default, this won't override the default logger.
// WithLogger will set a custom Logger, which will override the default logger.
func WithLogger(l Logger) ProviderOption {
return configFunc(func(c *config) error {
c.logger = l
Expand Down Expand Up @@ -195,9 +193,6 @@ type config struct {
allowMissing bool
disableGlobalRegistry bool

// Let's not expose the Logger just yet. Ideally we consolidate on the std lib slog package
// added in go1.21 and then expose that (if that's even necessary). For now, just use the std
// lib log package.
logger Logger
}

Expand Down

0 comments on commit 8f6abb6

Please sign in to comment.