Fix migrations for redshift (not working out of the box right now) #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
reviewed
Jul 19, 2023
db.go
Outdated
| @@ -16,13 +16,13 @@ func OpenDBWithDriver(driver string, dbstring string) (*sql.DB, error) { | |||
| case "mssql": | |||
| driver = "sqlserver" | |||
| case "redshift": | |||
| driver = "postgres" | |||
| driver = "pgx" | |||
There was a problem hiding this comment.
The alternative is to remove this override entirely, which I think is more correct.
In the CLI we use pgx since we're solely responsible for picking the driver, but in this case a user might be using lib/pq and an override to pgx would fail.
Probably best to just remove it and leave this up to the caller.
There was a problem hiding this comment.
Removed in e3dbb9b
I believe this should fix the issue for existing users who want to use lib/pq
Also added an override back to the CLI code to use pgx driver.
In order to fix migrations in redshift that do not work out of the box right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redshift migrations configured to use pq driver (https://github.com/lib/pq) which is not imported into project. Because of that error is being thrown.
postgres migrations use pgx driver (https://github.com/jackc/pgx)
2 possible solutions here, either import pq or change redshift driver to pgx. This PR is with change from pq to pgx for redshift