This repository has been archived by the owner on Nov 23, 2018. It is now read-only.
Adding format=mp4 parameter to convert gif files into mp4 (reduces file size) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ADD http://sourceforge.net/projects/libjpeg-turbo/files/1.4.2/libjpeg-turbo-official_1.4.2_amd64.deb/download /tmp/libjpeg-turbo-official_1.4.2_amd64.deb | ||
| RUN cd /tmp && dpkg -i /tmp/libjpeg-turbo-official_1.4.2_amd64.deb && \ | ||
| echo /opt/libjpeg-turbo/lib64 > /etc/ld.so.conf.d/libjpeg-turbo.conf && ldconfig | ||
| RUN wget -q https://sourceforge.net/projects/libjpeg-turbo/files/1.4.2/libjpeg-turbo-official_1.4.2_amd64.deb/download -O /tmp/libjpeg-turbo-official_1.4.2_amd64.deb && \ |
There was a problem hiding this comment.
The ADD command was downloading the sources each time docker build was called. This RUN operation does the same and it's cached by its docker layer, no need to download it each time.
There was a problem hiding this comment.
Very interesting catch!
| @@ -345,6 +368,17 @@ func (i *Image) sizeFrames(sz *imgry.Sizing) error { | |||
| } | |||
|
|
|||
| func (i *Image) WriteToFile(fn string) error { | |||
| if i.convertFormat != i.format { | |||
| if i.convertFormat == "mp4" { | |||
There was a problem hiding this comment.
This is an special case, we may be able to support different destination files, but for now we only expect mp4. This is only for writing the file to disk.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.