Skip to content
This repository has been archived by the owner on Jan 6, 2019. It is now read-only.

upgrade puppet to 1.6 and Dockerfile node version #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkirank
Copy link

@mkirank mkirank commented Aug 9, 2018

No description provided.

@marcellerusu
Copy link
Contributor

Is there a reason to move to node 10.x? 10 is not LTS yet unless I'm misreading the chart https://github.com/nodejs/Release#release-schedule

Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is node:10.6 preferred by Puppeteer project itself?

@marcellerusu
Copy link
Contributor

https://github.com/GoogleChrome/puppeteer/blob/master/package.json#L8

puppeteer seems to support back to 6.4 but doesn't say anything (I can find) about preferences, I assume they stick with the current LTS version.

@VojtechVitek
Copy link
Contributor

Yeah, they still use https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md.

But I'm fine with updating to a newer version, if everything works OK. We're in Docker world, I'm not really worried that it's not a LTS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants