Refactor builds from res/pokemon/*/data.json #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhearachel
force-pushed
the
pokemon
branch
3 times, most recently
from
137ed37 to
9d6dc60
Compare
h2o-DS
reviewed
Jan 21, 2025
adrienntindall
requested changes
Jan 21, 2025
lhearachel
force-pushed
the
pokemon
branch
2 times, most recently
from
72dd777 to
1eff5a8
Compare
This new code is responsible for packing the following archives: - `pl_personal` -> basic information for each species: stats, types, etc. - `evo` -> evolution lines for each species - `wotbl` -> by-level learnsets for each species - `ppark` -> catching show data for each species - `height` -> y-offsets for front and back sprites for each species - `pl_poke_data` -> sprite-rendering data for each species: animation ID, frame data, shadow size and offsets, etc. Additionally, the following headers are generated: - `res/pokemon/tutorable_moves.h` -> A listing of moves taught by each tutor and how much each move costs to be tutored - `res/pokemon/species_learnsets_by_tutor.h` -> An array of bitmasks for each species designating which moves can be tutored to that species
adrienntindall
approved these changes
Jan 22, 2025
github-actions bot
pushed a commit
to lhearachel/pokeplatinum
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR. As a general summary, the following actions have been taken:
include/pokemon.hhas been cleaned up, and some additional code related to evolutions and learnsets has been documented further.pl_personal,evo, andwotblhave been extracted to a standalone filestruct_defs/species.h.metanghas been added as a dependency as the successor toconstgen. Its offerings are more robust, and those are on full display here.datagenis a new internal tool to replacejson2bin. It makes use ofTencent/rapidjsonto parse these JSON files and generate a slew of all relevant NARCs and generated headers.json2binusage for parsing thesedata.jsonfiles has been removed.data.jsonfiles has changed. A migration script has been provided undertools/scripts/migrationfor users to move any changes that they have made to the new schema.Next Steps
pokedex.jsonfor each species and refactor build into a single executable.pokegra,poke_icon, andotherpoke.