Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Pokedex_Search #351

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Document Pokedex_Search #351

merged 3 commits into from
Jan 28, 2025

Conversation

h2o-DS
Copy link
Contributor

@h2o-DS h2o-DS commented Jan 27, 2025

ov21_021D85B0 -> pokedex_search
Moved UnkStruct_ov21_021D157C to ov21_021D0D80 and renamed PokedexLoadingScreen
Cleaned up pokedex_sort enums

This is the screen where the Pokedex filters can be selected.

h2o-DS added 2 commits January 26, 2025 21:32
@h2o-DS
Pokedex_Search
2c706fb 
ov21_021D85B0 -> pokedex_search
Moved UnkStruct_ov21_021D157C to ov21_021D0D80 and renamed PokedexLoadingScreen
Cleaned up pokedex_sort enums
@h2o-DS
Merge branch 'pret:main' into Pokedex_Menu_Text
922ee32
lhearachel
lhearachel reviewed Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great! Just a few comments for polish, and one extra thought.

include/overlay021/ov21_021D0D80.h Outdated Show resolved Hide resolved
include/overlay021/pokedex_search.h Outdated Show resolved Hide resolved
src/overlay021/ov21_021D0D80.c Outdated Show resolved Hide resolved
src/overlay021/ov21_021D0D80.c Outdated Show resolved Hide resolved
src/overlay021/pokedex_search.c Outdated Show resolved Hide resolved
src/overlay021/pokedex_search.c Outdated Show resolved Hide resolved
src/overlay021/pokedex_search.c Show resolved Hide resolved
src/overlay021/pokedex_search.c Outdated Show resolved Hide resolved
src/overlay021/pokedex_search.c Outdated Show resolved Hide resolved
@h2o-DS
Polish
08dad45 
config -> bgConfig
MAX_X enums
SearchSettings->exitFlag
1535 -> SEQ_SE_DP_Z_SEARCH
Removed unnecessary scope blocks
@lhearachel lhearachel merged commit 34a091f into pret:main Jan 28, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 28, 2025
@lhearachel
Merge pull request #351 from h2o-DS/Pokedex_Menu_Text
f1ba7a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhearachel lhearachel lhearachel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h2o-DS @lhearachel